Re: [PATCHv3 0/2] qemu: mitigate 'qemu disk buffers not flushed' problem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/07/2012 10:18 AM, Laine Stump wrote:
> These two patches do two things:
> 
> 1) Drop the driver lock while sleeping during qemuProcessKill(), so
> that it can wait for a longer period without locking up all other
> libvirtd threads.
> 
> This patch is a slight re-work of a patch Eric sent to the list back
> in November.

I like how you changed things to only unlock once, compared to my first
attempt.

> 
> 2) Wait for a considerably longer period after sending SIGTERM before
> sending SIGKILL. 

ACK series from me; although I'm a bit biased (having written half the
first patch before you reworked it), so you still might feedback from
danpb before pushing.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]