On Thu, Feb 02, 2012 at 17:33:20 -0700, Eric Blake wrote: > Our syntax checker missed all-lower-case variables (this will > be fixed by the next .gnulib update). Additionally, anywhere > that we mix in-tree files with generated files, automake recommends > listing builddir prior to srcdir for VPATH builds. > > * src/Makefile.am (*_la_CFLAGS): Favor $(top_srcdir). > (INCLUDES): Likewise, and follow automake recommendations on > builddir before srcdir. > * python/Makefile.am (INCLUDES): Swap directory order. > * tests/Makefile.am (INCLUDES): Likewise. > * tools/Makefile.am (INCLUDES): Likewise. > * daemon/Makefile.am (INCLUDES): Likewise. > (libvirtd.init, libvirtd.service): Favor $(). > * examples/hellolibvirt/Makefile.am (hellolibvirt_LDADD): > Likewise. > * examples/openauth/Makefile.am (openauth_LDADD): Likewise. > * examples/dominfo/Makefile.am (INCLUDES): Drop dead include. > * examples/domsuspend/Makefile.am (INCLUDES): Likewise. > --- > daemon/Makefile.am | 20 +++++----- > examples/dominfo/Makefile.am | 4 +- > examples/domsuspend/Makefile.am | 4 +- > examples/hellolibvirt/Makefile.am | 4 +- > examples/openauth/Makefile.am | 4 +- > python/Makefile.am | 4 +- > src/Makefile.am | 70 ++++++++++++++++++------------------ > tests/Makefile.am | 9 ++--- > tools/Makefile.am | 12 +++--- > 9 files changed, 65 insertions(+), 66 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list