On 02/01/2012 12:40 PM, Laine Stump wrote:
> On 02/01/2012 12:05 AM, Eric Blake wrote:
>> Qemu is adding the ability to do a partial rebase. That is, given:
>>
>> base<- intermediate<- current
>>
>> virDomainBlockPull will produce:
>>
>> current
>>
>> but qemu now has the ability to leave base in the chain, to produce:
>>
>> base<- current
>>
>> +int virDomainBlockRebase(virDomainPtr dom, const char *disk,
>> + const char *base, unsigned long bandwidth,
>> + unsigned int flags)
>> +{
>> + virConnectPtr conn;
>> +
>> + VIR_DOMAIN_DEBUG(dom, "disk=%p, base=%s bandwidth=%lu, flags=%x",
>
> disk is just a character string, isn't it? If so, why not use %s instead
> of %p?
Copy-and-paste from virDomainBlockPull, so I'll fix up both places
before pushing.
>
> Otherwise, this is all pretty straightforward. ACK.
Thanks for the review.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list