On 02/01/2012 06:03 AM, Peter Krempa wrote:
> This patch adds API to modify domain metadata for running and stopped
> domains. The api supports changing description, title as well as the
> newly added <metadata> element. The API has support for storing data in
> the metadata element using xml namespaces.
>
> * include/libvirt/libvirt.h.in
> * src/libvirt_public.syms
> - add function headers
> - add enum to select metadata to operate on
> - export functions
> * src/libvirt.c
> - add public api implementation
> * src/driver.h
> - add driver support
> * src/remote/remote_driver.c
> * src/remote/remote_protocol.x
> - wire up the remote protocol
> * include/libvirt/virterror.h
> * src/util/virterror.c
> - add a new error message note that metadata for domain are
> missing
> ---
> include/libvirt/libvirt.h.in | 24 ++++++
> include/libvirt/virterror.h | 1 +
> src/driver.h | 16 ++++
> src/libvirt.c | 178 ++++++++++++++++++++++++++++++++++++++++++
> src/libvirt_public.syms | 2 +
> src/remote/remote_driver.c | 2 +
> src/remote/remote_protocol.x | 24 ++++++-
> src/remote_protocol-structs | 19 +++++
> src/util/virterror.c | 6 ++
> 9 files changed, 271 insertions(+), 1 deletions(-)
ACK with one nit:
> +++ b/src/util/virterror.c
> @@ -1226,6 +1226,12 @@ virErrorMsg(virErrorNumber error, const char *info)
> else
> errmsg = _("operation aborted: %s");
> break;
> + case VIR_ERR_NO_DOMAIN_METADATA:
> + if (info == NULL)
> + errmsg = _("metadata not found");
> + else
> + errmsg = _("metadata not found");
The else branch should be:
"metadata not found: %s"
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list