On 30.01.2012 20:04, Eric Blake wrote: > Our existing virDomainBlockResize takes an unsigned long long > argument; if that command is later taught a DELTA and SHRINK flag, > we cannot change its type without breaking API (but at least such > a change would be ABI compatible). Meanwhile, the only time a > negative size makes sense is if both DELTA and SHRINK are used > together, but if we keep the argument unsigned, applications can > pass the positive delta amount by which they would like to shrink > the system, and have the flags imply the negative value. So, > since this API has not yet been released, and in the interest of > consistency with existing API, we swap virStorageVolResize to > always pass an unsigned value. > > * include/libvirt/libvirt.h.in (virStorageVolResize): Use unsigned > argument. > * src/libvirt.c (virStorageVolResize): Likewise. > * src/driver.h (virDrvStorageVolUpload): Adjust clients. > * src/remote/remote_protocol.x (remote_storage_vol_resize_args): > Likewise. > * src/remote_protocol-structs: Regenerate. > Suggested by Daniel P. Berrange. > --- > include/libvirt/libvirt.h.in | 2 +- > src/driver.h | 2 +- > src/libvirt.c | 17 +++++++++-------- > src/remote/remote_protocol.x | 2 +- > src/remote_protocol-structs | 2 +- > 5 files changed, 13 insertions(+), 12 deletions(-) > ACK Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list