On Wed, Jan 25, 2012 at 11:44:56AM -0700, Eric Blake wrote:
> On 01/25/2012 09:38 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> >
> > In preparation for the patch to include Murmurhash3, which
> > introduces a virhashcode.h and virhashcode.c files, rename
> > the existing hash.h and hash.c to virhash.h and virhash.c
> > respectively.
> > ---
> > po/POTFILES.in | 2 +-
> > src/Makefile.am | 2 +-
> > src/conf/domain_conf.h | 2 +-
> > src/conf/nwfilter_conf.h | 2 +-
> > src/conf/nwfilter_params.h | 2 +-
> > src/cpu/cpu_generic.c | 2 +-
> > src/qemu/qemu_monitor.h | 2 +-
> > src/qemu/qemu_monitor_text.h | 1 -
> > src/uml/uml_conf.h | 2 +-
> > src/util/cgroup.c | 2 +-
> > src/util/{hash.c => virhash.c} | 2 +-
> > src/util/{hash.h => virhash.h} | 0
> > src/xen/xen_driver.h | 2 +-
> > src/xen/xm_internal.c | 2 +-
> > tests/Makefile.am | 10 +++++-----
> > tests/{hashdata.h => virhashdata.h} | 0
> > tests/{hashtest.c => virhashtest.c} | 4 ++--
>
> Gotta love git diffs of a file rename :)
>
> > +++ b/src/qemu/qemu_monitor_text.h
> > @@ -28,7 +28,6 @@
> > # include "internal.h"
> >
> > # include "qemu_monitor.h"
> > -# include "hash.h"
> >
>
> Huh - wonder why we had a stale header.
It is & it isn't stale. This File does reference virHashTablePtr in
the API, but we inherit the include of virhash.h, from the qemu_monitor.h
line just above, which defines all the same API contracts,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list