Re: [PATCH v2 1/3] qemu_agent: Create file system freeze and thaw functions

["MATSUDA, Daiki" <matsudadik@xxxxxxxxxxxxxxxxx>]

I am happy that you provide the patches.

> These functions simply issue command to guest agent which
> should freeze or unfreeze all file systems within guest.
> ---
>   src/qemu/qemu_agent.c |   74 +++++++++++++++++++++++++++++++++++++++++++++++++
>   src/qemu/qemu_agent.h |    3 ++
>   2 files changed, 77 insertions(+), 0 deletions(-)
>
> diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
> index 6a7c7b3..9df5546 100644
> --- a/src/qemu/qemu_agent.c
> +++ b/src/qemu/qemu_agent.c
> @@ -1110,3 +1110,77 @@ int qemuAgentShutdown(qemuAgentPtr mon,
>       virJSONValueFree(reply);
>       return ret;
>   }
> +
> +/*
> + * qemuAgentFSFreeze:
> + * @mon: Agent
> + *
> + * Issue guest-fsfreeze-freeze command to guest agent,
> + * which freezes all mounted file systems and returns
> + * number of frozen file systems on success.
> + *
> + * Returns: number of file system frozen on success,
> + *          -1 on error.
> + */
> +int qemuAgentFSFreeze(qemuAgentPtr mon)
> +{
> +    int ret = -1;
> +    virJSONValuePtr cmd;
> +    virJSONValuePtr reply = NULL;
> +
> +    cmd = qemuAgentMakeCommand("guest-fsfreeze-freeze", NULL);
> +
> +    if (!cmd)
> +        return -1;
> +
> +    if (qemuAgentCommand(mon, cmd,&reply)<  0 ||
> +        qemuAgentCheckError(cmd, reply)<  0)
> +        goto cleanup;
> +
> +    if (virJSONValueObjectGetNumberInt(reply, "return",&ret)<  0) {
> +        qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                        _("malformed return value"));
> +    }
> +
> +cleanup:
> +    virJSONValueFree(cmd);
> +    virJSONValueFree(reply);
> +    return ret;
> +}
> +
> +/*
> + * qemuAgentFSThaw:
> + * @mon: Agent
> + *
> + * Issue guest-fsfreeze-thaw command to guest agent,
> + * which unfreezes all mounted file systems and returns
> + * number of thawed file systems on success.
> + *
> + * Returns: number of file system thawed on success,
> + *          -1 on error.
> + */
> +int qemuAgentFSThaw(qemuAgentPtr mon)
> +{
> +    int ret = -1;
> +    virJSONValuePtr cmd;
> +    virJSONValuePtr reply = NULL;
> +
> +    cmd = qemuAgentMakeCommand("guest-fsfreeze-thaw", NULL);
> +
> +    if (!cmd)
> +        return -1;
> +
> +    if (qemuAgentCommand(mon, cmd,&reply)<  0 ||
> +        qemuAgentCheckError(cmd, reply)<  0)
> +        goto cleanup;
> +
> +    if (virJSONValueObjectGetNumberInt(reply, "return",&ret)<  0) {
> +        qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                        _("malformed return value"));
> +    }
> +
> +cleanup:
> +    virJSONValueFree(cmd);
> +    virJSONValueFree(reply);
> +    return ret;
> +}

But qemuAgentFSFreeze() and qemuAgentFSThaw() are almost same. In 
addition, qemu guest agent provides status option for FS Freezer. So, 
could you change to following?

VIR_ENUM_DECL(qemuAgentFSFreezeCtlMode);

VIR_ENUM_IMPL(qemuAgentFSFreezeCtlMode,
              QEMU_AGENT_FSFREEZE_LAST,
              "guest-fsfreeze-freeze",
              "guest-fsfreeze-thaw",
              "guest-fsfreeze-status");

int qemuAgentFSFreezeCtl(qemuAGentPtr mon, qemuAgentFSFreezeCtlMode mode){
    ...
    cmd = qemuAgentMakeCommand(qemuAgentFSFreezeCtlModeToString(mode), 
NULL);
    ...

> diff --git a/src/qemu/qemu_agent.h b/src/qemu/qemu_agent.h
> index 93c2ae7..df59ef7 100644
> --- a/src/qemu/qemu_agent.h
> +++ b/src/qemu/qemu_agent.h
> @@ -66,4 +66,7 @@ typedef enum {
>   int qemuAgentShutdown(qemuAgentPtr mon,
>                         qemuAgentShutdownMode mode);
>
> +int qemuAgentFSFreeze(qemuAgentPtr mon);
> +int qemuAgentFSThaw(qemuAgentPtr mon);
> +
>   #endif /* __QEMU_AGENT_H__ */

Similarly
int qemuAgentFSFreezeCtl(qemuAgentPtr mon, qemuAgentFSFreezeCtlMode mode);

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list