On 24.01.2012 19:57, Jiri Denemark wrote:
> On Tue, Jan 24, 2012 at 18:37:45 +0100, Michal Privoznik wrote:
>> to cmdSnapshotCreate and cmdSnapshotCreateAs.
>> ---
>> tools/virsh.c | 6 ++++++
>> tools/virsh.pod | 14 ++++++++++++--
>> 2 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/virsh.pod b/tools/virsh.pod
>> index 72c6d8f..b1f75de 100644
>> --- a/tools/virsh.pod
>> +++ b/tools/virsh.pod
>> @@ -2046,7 +2046,8 @@ used to represent properties of snapshots.
>> =over 4
>>
>> =item B<snapshot-create> I<domain> [I<xmlfile>] {[I<--redefine> [I<--current>]]
>> -| [I<--no-metadata>] [I<--halt>] [I<--disk-only>] [I<--reuse-external]}
>> +| [I<--no-metadata>] [I<--halt>] [I<--disk-only>] [I<--reuse-external]
>> +[I<--quiesce>]}
>>
>> Create a snapshot for domain I<domain> with the properties specified in
>> I<xmlfile>. Normally, the only properties settable for a domain snapshot
>> @@ -2088,6 +2089,10 @@ external snapshot with a destination of an existing file, then the
>> existing file is truncated and reused; otherwise, a snapshot is refused
>> to avoid losing contents of the existing files.
>>
>> +If I<--quiesce> is specified, libvirt will try to use guest agent
>> +to freeze and unfreeze domain's mounted file systems. However,
>> +currently this requires I<--disk-only> to be passed as well.
>> +
>
> I'm not a native speaker but I feel like "libvirt will try to use guest agent"
> suggests that the snapshot will still be created even though guest agent
> couldn't be used for freezing guest's file systems. I'd rather be explicit
> about the fact that no guest agent implies no snapshot.
>
Okay, reworded in v2.
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list