On Fri, Jan 20, 2012 at 11:11:57PM +0200, Zeeshan Ali (Khattak) wrote: > From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> > > --- > libvirt-gconfig/libvirt-gconfig-domain.c | 115 +++++++++++++++++++++++++++++ > libvirt-gconfig/libvirt-gconfig-domain.h | 8 ++ > libvirt-gconfig/libvirt-gconfig-helpers.c | 4 +- > libvirt-gconfig/libvirt-gconfig.sym | 2 + > 4 files changed, 128 insertions(+), 1 deletions(-) The API design gets my ACK, will defer to Christophe for the other code review points. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list