On 01/19/2012 11:38 PM, Taku Izumi wrote: > > Other virsh domifXXX commands can accept target name > as a parameter to specify interface. From viewpoint of > consistency, virsh domif-setlink command should accept > target name as a parameter. This patch achieves this. > > Signd-off-by: Taku Izumi <izumi.taku@xxxxxxxxxxxxxx> > --- > tools/virsh.c | 25 ++++++++++++++++++------- > tools/virsh.pod | 3 ++- > 2 files changed, 20 insertions(+), 8 deletions(-) > > Index: libvirt/tools/virsh.c > =================================================================== > --- libvirt.orig/tools/virsh.c > +++ libvirt/tools/virsh.c > @@ -1344,8 +1344,11 @@ cmdDomIfSetLink (vshControl *ctl, const > virDomainPtr dom; > const char *iface; > const char *state; > - const char *mac; > + const char *value; > const char *desc; > + unsigned char macaddr[VIR_MAC_BUFLEN]; > + const char *element; > + const char *attribute; Same renaming exercise as in 1/2, and same ACK and push. Actually, I merged these into one patch, since the subject line of both patches implied that both functions were being modified at once. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list