On Wed, Jan 18, 2012 at 02:53:50PM +0000, Richard W.M. Jones wrote: > There is a typo in the commit message: mplement -> implement > > On Wed, Jan 18, 2012 at 03:12:09PM +0800, Lai Jiangshan wrote: > > +/* Upper limit on list of physical cpu parameters. */ > > +const REMOTE_DOMAIN_PCPUS_USAGE_PARAMETERS_MAX = 32; > > This number is bigger than the previous version, but is there some > reason not to make it very big (eg. 4096)? It's not completely > unknown to have machines with more than 32 physical CPUs. > 8*4096 bytes is fine for the libvirt protocol. Agreed, 4096 is the absolute *minimum* we should use. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list