On 01/12/2012 08:39 PM, Michael Ellerman wrote: > We can't call qemuCapsExtractVersionInfo() from test code, because it > expects to be able to call the emulator, and for testing we have fake > emulators that can't be executed. For that reason qemuxml2argvtest.c > doesn't call qemuDomainAssignPCIAddresses(), instead it open codes its > own version. > > That means we can't call qemuDomainAssignAddresses() from the test code, > instead we need to manually call qemuDomainAssignSpaprVioAddresses(). > > Also add logic to cope with qemuDomainAssignSpaprVioAddresses() failing, > so that we can write a test that checks for a known failure in there. > > Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx> > --- > src/qemu/qemu_command.c | 2 +- > src/qemu/qemu_command.h | 1 + > tests/qemuxml2argvtest.c | 18 +++++++++++++----- > 3 files changed, 15 insertions(+), 6 deletions(-) ACK and pushed. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list