On 01/11/2012 07:16 AM, Daniel P. Berrange wrote: > On Wed, Jan 11, 2012 at 07:09:37AM -0700, Eric Blake wrote: >> The autobuilder pointed out an odd failure on mingw: >> ../../src/interface/netcf_driver.c:644:5: error: unknown field 'close_used_without_including_unistd_h' specified in initializer >> cc1: warnings being treated as errors >> >> This is because the gnulib headers #define close in order to work >> around some odd mingw problems with close(), but it happens to >> also affect field members declared with a name of struct foo.close. >> As long as the same headers are included for the definition and use >> of the struct, the #define doesn't matter, but the netcf file hit >> an instance where things were in a different order. Fix this for >> all clients that use a struct member named 'close'. >> > > ACK. Pushed. > > I sent another patch to avoid triggering this bug too, which we probably > still want to add. Yes, yours also makes sense to push. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list