On 01/09/2012 07:29 AM, Osier Yang wrote:
> ---
> src/remote/remote_driver.c | 1 +
> src/remote/remote_protocol.x | 12 +++++++++++-
> src/remote_protocol-structs | 9 +++++++++
> 3 files changed, 21 insertions(+), 1 deletions(-)
>
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 7580477..74225af 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -4739,6 +4739,7 @@ static virDriver remote_driver = {
> .domainGetBlockIoTune = remoteDomainGetBlockIoTune, /* 0.9.8 */
> .domainSetNumaParameters = remoteDomainSetNumaParameters, /* 0.9.9 */
> .domainGetNumaParameters = remoteDomainGetNumaParameters, /* 0.9.9 */
> + .domainNormalizeDeviceXML = remoteDomainNormalizeDeviceXML, /* 0.9.10 */
> };
>
> static virNetworkDriver network_driver = {
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index ca739ff..e6a51fb 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -2348,6 +2348,15 @@ struct remote_node_suspend_for_duration_args {
> unsigned int flags;
> };
>
> +struct remote_domain_normalize_device_xml_args {
> + remote_nonnull_domain dom;
Obvious changes here if we go with a different API.
> + remote_nonnull_string device_xml;
> + unsigned int flags;
> +};
> +
> +struct remote_domain_normalize_device_xml_ret {
> + remote_nonnull_string xml;
> +};
>
> /*----- Protocol. -----*/
>
> @@ -2653,7 +2662,8 @@ enum remote_procedure {
> REMOTE_PROC_DOMAIN_SET_NUMA_PARAMETERS = 254, /* autogen autogen */
> REMOTE_PROC_DOMAIN_GET_NUMA_PARAMETERS = 255, /* skipgen skipgen */
> REMOTE_PROC_DOMAIN_SET_INTERFACE_PARAMETERS = 256, /* autogen autogen */
> - REMOTE_PROC_DOMAIN_GET_INTERFACE_PARAMETERS = 257 /* skipgen skipgen */
> + REMOTE_PROC_DOMAIN_GET_INTERFACE_PARAMETERS = 257, /* skipgen skipgen */
> + REMOTE_PROC_DOMAIN_NORMALIZE_DEVICE_XML = 258 /* autogen autogen priority:high */
This part looks fine - it shouldn't be making any monitor calls, so
using the high-priority queue won't starve anything.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list