All that was missing to fix it was gvir_config_object_remove_attribute which now exists. --- libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c b/libvirt-gconfig/libvirt-gconfig-domain-filesys.c index 3665d22..ef942f8 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-filesys.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-filesys.c @@ -106,7 +106,8 @@ void gvir_config_domain_filesys_set_driver_type(GVirConfigDomainFilesys *filesys node, "type", GVIR_TYPE_CONFIG_DOMAIN_FILESYS_DRIVER_TYPE, type, NULL); - /* else XXX delete existing attribute ? */ + else + gvir_config_object_remove_attribute(node, "type"); g_object_unref(G_OBJECT(node)); } -- 1.7.7.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list