On 12/31/2011 02:12 PM, Eric Blake wrote:
> On 12/29/2011 12:33 AM, Hu Tao wrote:
>> * src/qemu/qemu_driver.c: implement the qemu driver support
>> ---
>> src/qemu/qemu_driver.c | 353 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 353 insertions(+), 0 deletions(-)
>
>> + if (STREQ(param->field, VIR_DOMAIN_BANDWIDTH_IN_AVERAGE)) {
>> + if (param->type != VIR_TYPED_PARAM_UINT) {
>> + qemuReportError(VIR_ERR_INVALID_ARG, "%s",
>> + _("invalid type for bandwidth average tunable, expected a 'unsigned int'"));
>
> s/a 'unsigned int'/an 'unsigned int'/
> Also, these are long lines.
I think I'll refactor this into a set of helper methods; patch coming up
soon.
>
>> + /* average is mandatory, peak and burst is optional. So if no
>
> s/peak and burst is/peak and burst are/
Meanwhile, I've posted a patch to address all my comments:
https://www.redhat.com/archives/libvir-list/2012-January/msg00018.html
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list