On 01/02/2012 04:21 PM, Daniel Veillard wrote: > On Mon, Jan 02, 2012 at 03:23:54PM +0100, Michal Novotny wrote: >> Hi, >> this is the fifth version of my SRV record for DNSMasq patch rebased >> for the current codebase to the bridge driver and libvirt XML file to >> include support for the SRV records in the DNS. The syntax is based on >> DNSMasq man page and tests for both xml2xml and xml2argv were added as >> well. There are some things written a better way in comparison with >> version 4, mainly there's no hack in tests/networkxml2argvtest.c and >> also the xPath context is changed to use a simpler query using the >> virXPathInt() function relative to the current node. >> >> Also, the patch is also fixing the networkxml2argv test to pass both >> checks, i.e. both unit tests and also syntax check. >> >> Please review, > Yeah, it looks good to me, actually we should have pushed it before in > december but I forgot it. Since it's relatively contained, I'm pushing > it in spite of the freeze, we already delayed it over one release. Blame > me if it breaks something it was my fault I forgot the patch ! > > ACK and pushed, > > thanks ! > > Daniel > Thanks for pushing it and it's been tested also today and it compiled and all tests passed both check and syntax-check phases so don't worry, it shouldn't break anything :-) Thanks again for pushing it, Michal -- Michal Novotny <minovotn@xxxxxxxxxx>, RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list