On 12/22/2011 11:39 AM, Laine Stump wrote:
> This patch adds two capabilities flags to deal with various aspects
> of supporting SG_IO commands on virtio-blk-pci devices:
>
> QEMU_CAPS_VIRTIO_BLK_SCSI
> set if -device virtio-blk-pci accepts the scsi="on|off" option
> When present, this is on by default, but can be set to off to disable
> SG_IO functions.
>
> QEMU_CAPS_VIRTIO_BLK_SG_IO
> set if SG_IO commands are supported in the virtio-blk-pci driver
> (present since qemu 0.11 according to a qemu developer, if I
> understood correctly)
> ---
> src/qemu/qemu_capabilities.c | 8 ++++++++
> src/qemu/qemu_capabilities.h | 3 +++
> 2 files changed, 11 insertions(+), 0 deletions(-)
ACK. This patch is uncontroversial, even while we debate on the proper
XML representation to use in patch 2/2.
> +++ b/src/qemu/qemu_capabilities.h
> @@ -118,6 +118,9 @@ enum qemuCapsFlags {
> QEMU_CAPS_NO_ACPI = 78, /* -no-acpi */
> QEMU_CAPS_FSDEV_READONLY =79, /* -fsdev readonly supported */
While you are touching this area of code, would you mind inserting the
missing space after '=' on this line?
>
> + QEMU_CAPS_VIRTIO_BLK_SCSI = 80, /* virtio-blk-pci.scsi */
> + QEMU_CAPS_VIRTIO_BLK_SG_IO = 81, /* support for SG_IO commands, reportedly added in 0.11 */
> +
> QEMU_CAPS_LAST, /* this must always be the last item */
> };
>
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list