On 12/20/2011 08:21 AM, Michal Privoznik wrote:
> This patch alters saving code, so we can report progress
> and allow cancel via ^C.
> ---
> tools/virsh.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++-------
> tools/virsh.pod | 8 +++---
> 2 files changed, 68 insertions(+), 13 deletions(-)
>
> + virDomainFree (dom);
> + ignore_value(safewrite(data->writefd, &ret, sizeof(ret)));
> +}
> +
> +static bool
Trailing space on that blank line. Make sure your series is
'syntax-check' clean.
> +
> + ret = do_watch_job(ctl, dom, verbose, p[0], 0, NULL, "Managedsave");
_("Managedsave")
ACK.
Depending on your reaction to my review on 1/4, you may have some minor
rebasing to do on function names used in 2-4/4.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list