On 12/20/2011 08:21 AM, Michal Privoznik wrote:
> This patch alters dumping code, so we can report progress
> and allow cancel via ^C.
> ---
> tools/virsh.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++-------
> tools/virsh.pod | 8 +++---
> 2 files changed, 73 insertions(+), 14 deletions(-)
>
>
> + sigemptyset(&sigmask);
> + sigaddset(&sigmask, SIGINT);
> + if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0)
> + goto out_sig;
> +
> if (!vshConnectionUsability(ctl, ctl->conn))
> - return false;
> + goto out;
Is it any more efficient to do the argument validation prior to the
pthread_sigmask?
> +
> + ret = do_watch_job(ctl, dom, verbose, p[0], 0, NULL, "Dump");
_("Dump")
ACK.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list