Re: [PATCH] virsh: Print error message if argument parsing fails for cmdNodesuspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/2011 07:31 AM, Michal Privoznik wrote:
>>
>> -    if (vshCommandOptString(cmd, "target", &target) < 0)
>> +    if (vshCommandOptString(cmd, "target", &target) < 0) {
>> +        vshError(ctl, _("Invalid suspend target argument"));
> I'd do s/suspend // in all strings you're adding.

Compilation without NLS will trigger gcc warnings that you are using a
printf-style interface without any %.  Write this as vshError(ctl, "%s",
_("Invalid target argument")).

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]