On 12/08/2011 02:05 PM, Laine Stump wrote: > On 12/08/2011 03:38 PM, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=738725 >> >> Commit ecd8725 tried to silence a spurious warning on the initial >> libvirt install, and commit ba6cbb1 tried to fix up the logic to the >> correct Fedora version, but the warning was still present due to a >> logic bug: since %{fedora} and %{rhel} are never simulatanously >> set, then 0%{rhel}<= 6 made the %if always true. Checking for >> minimum versions (via>=) is okay, but checking for maximum versions >> (via<=) requires a prerequisite test that the platform being tested >> is non-zero. >> > ACK. Thanks; pushed. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list