Re: [PATCH] virsh: correct the cmdDomIfGetLink function return value error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/2011 05:25 PM, Peter Krempa wrote:
On 12/08/2011 07:30 AM, ajia@xxxxxxxxxx wrote:
From: Alex Jia<ajia@xxxxxxxxxx>

* tools/virsh.c: Although finding interface with matching mac addr, forgot to
set 'ret' boolean value to 'true'.

* how to reproduce?
   % virsh domif-getlink<guest name> <interface mac>
   % echo $?

Signed-off-by: Alex Jia<ajia@xxxxxxxxxx>
---

Your patch failed to apply as the context is ambigous with a function not far away from this. Also 3-way merge failed due to invalid git hashes. You probably had more patches on a branch which are not upstream.

Anyways, thanks for finding this. I'm going to push a fix based on your patch.



Peter, thanks, you probably need to ACK '[PATCH] virsh: plug memory leak on cmdBlkdeviotune() sucessful path' and '[PATCH] virsh: plug memory leak on cmdDomIfGetLink() sucessful path' firstly, and Osier have given a ACKed.

Alex

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]