This email is automatically generated. The test result is based on the following git commit: d336dbd spec: fix sanlock dependency Analysis summary report: ------------------------ Files analyzed : 241 Total LoC input to cov-analyze : 328912 Functions analyzed : 7999 Paths analyzed : 923483 Defect occurrences found : 71 Total 7 ATOMICITY 3 CHECKED_RETURN 14 DEADCODE 7 FORWARD_NULL 13 LOCK 2 NEGATIVE_RETURNS 1 NULL_RETURNS 6 RESOURCE_LEAK 1 RETURN_LOCAL 12 REVERSE_INULL 3 UNINIT 2 UNUSED_VALUE Exceeded path limit of 5000 paths in 0.49% of functions (normally up to 5% of functions encounter this limitation) For details, please see attachment. Regards, Alex
Error: ATOMICITY: /libvirt/src/util/event_poll.c:603: lock: Locking "eventLoop.lock.lock". /libvirt/src/util/event_poll.c:610: def: Assigning: "fds" = data that might be protected by the lock. /libvirt/src/util/event_poll.c:614: unlock: Unlocking "eventLoop.lock.lock". "fds" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/util/event_poll.c:632: lockagain: Locking "eventLoop.lock.lock" again. /libvirt/src/util/event_poll.c:636: use: Using an unreliable value of "fds" inside the second locked section. If the data that "fds" depends on was changed by another thread, this use might be incorrect. Error: ATOMICITY: /libvirt/src/rpc/virnetclientstream.c:386: lock: Locking "st->lock.lock". /libvirt/src/rpc/virnetclientstream.c:397: def: Assigning: "msg" = data that might be protected by the lock. /libvirt/src/rpc/virnetclientstream.c:410: unlock: Unlocking "st->lock.lock". "msg" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/rpc/virnetclientstream.c:412: lockagain: Locking "st->lock.lock" again. /libvirt/src/rpc/virnetclientstream.c:413: use: Using an unreliable value of "msg" inside the second locked section. If the data that "msg" depends on was changed by another thread, this use might be incorrect. Error: ATOMICITY: /libvirt/src/util/threadpool.c:95: lock: Locking "pool->mutex.lock". /libvirt/src/util/threadpool.c:129: def: Assigning: "pool->jobList.firstPrio" = data that might be protected by the lock. /libvirt/src/util/threadpool.c:143: unlock: Unlocking "pool->mutex.lock". "pool->jobList.firstPrio" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/util/threadpool.c:146: lockagain: Locking "pool->mutex.lock" again. /libvirt/src/util/threadpool.c:116: use: Using an unreliable value of "pool->jobList.firstPrio" inside the second locked section. If the data that "pool->jobList.firstPrio" depends on was changed by another thread, this use might be incorrect. Error: ATOMICITY: /libvirt/src/util/threadpool.c:146: lock: Locking "pool->mutex.lock". /libvirt/src/util/threadpool.c:129: def: Assigning: "pool->jobList.firstPrio" = data that might be protected by the lock. /libvirt/src/util/threadpool.c:143: unlock: Unlocking "pool->mutex.lock". "pool->jobList.firstPrio" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/util/threadpool.c:146: lockagain: Locking "pool->mutex.lock" again. /libvirt/src/util/threadpool.c:116: use: Using an unreliable value of "pool->jobList.firstPrio" inside the second locked section. If the data that "pool->jobList.firstPrio" depends on was changed by another thread, this use might be incorrect. Error: ATOMICITY: /libvirt/src/util/threadpool.c:146: lock: Locking "pool->mutex.lock". /libvirt/src/util/threadpool.c:135: def: Assigning: "pool->jobList.head" = data that might be protected by the lock. /libvirt/src/util/threadpool.c:143: unlock: Unlocking "pool->mutex.lock". "pool->jobList.head" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/util/threadpool.c:146: lockagain: Locking "pool->mutex.lock" again. /libvirt/src/util/threadpool.c:118: use: Using an unreliable value of "pool->jobList.head" inside the second locked section. If the data that "pool->jobList.head" depends on was changed by another thread, this use might be incorrect. Error: ATOMICITY: /libvirt/src/fdstream.c:146: lock: Locking "fdst->lock.lock". /libvirt/src/fdstream.c:153: def: Assigning: "cbopaque" = data that might be protected by the lock. /libvirt/src/fdstream.c:156: unlock: Unlocking "fdst->lock.lock". "cbopaque" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/fdstream.c:160: lockagain: Locking "fdst->lock.lock" again. /libvirt/src/fdstream.c:163: use: Using an unreliable value of "cbopaque" inside the second locked section. If the data that "cbopaque" depends on was changed by another thread, this use might be incorrect. Error: ATOMICITY: /libvirt/src/rpc/virnetclientstream.c:96: lock: Locking "st->lock.lock". /libvirt/src/rpc/virnetclientstream.c:109: def: Assigning: "cbOpaque" = data that might be protected by the lock. /libvirt/src/rpc/virnetclientstream.c:113: unlock: Unlocking "st->lock.lock". "cbOpaque" might now be unreliable because other threads can now change the data that it depends on. /libvirt/src/rpc/virnetclientstream.c:115: lockagain: Locking "st->lock.lock" again. /libvirt/src/rpc/virnetclientstream.c:119: use: Using an unreliable value of "cbOpaque" inside the second locked section. If the data that "cbOpaque" depends on was changed by another thread, this use might be incorrect. Error: CHECKED_RETURN: /libvirt/daemon/libvirtd.c:823: example_checked: "virAsprintf(configfile, "%s/.libvirt/libvirtd.conf", userdir)" has its value checked in "virAsprintf(configfile, "%s/.libvirt/libvirtd.conf", userdir) < 0". /libvirt/daemon/libvirtd.c:916: example_assign: Assigning: "ret" = return value from "virAsprintf(&data->mdns_name, "Virtualization Host")". /libvirt/daemon/libvirtd.c:926: example_checked: "ret" has its value checked in "ret < 0". /libvirt/daemon/libvirtd.c:922: example_assign: Assigning: "ret" = return value from "virAsprintf(&data->mdns_name, "Virtualization Host %s", localhost)". /libvirt/daemon/libvirtd.c:926: example_checked: "ret" has its value checked in "ret < 0". /libvirt/daemon/libvirtd.c:279: example_checked: "virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir)" has its value checked in "virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0". /libvirt/daemon/libvirtd.c:772: example_checked: "virAsprintf(&tmp, "%d:file:%s/log/libvirt/libvirtd.log", virLogGetDefaultPriority(), "/usr/local/var")" has its value checked in "virAsprintf(&tmp, "%d:file:%s/log/libvirt/libvirtd.log", virLogGetDefaultPriority(), "/usr/local/var") == -1". /libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2876: check_return: Calling function "virAsprintf" without checking return value (as is done elsewhere 425 out of 446 times). /libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2876: unchecked_value: No check of the return value of "virAsprintf(&protostr, "-d 01:80:c2:00:00:00 ")". Error: CHECKED_RETURN: /libvirt/daemon/libvirtd.c:823: example_checked: "virAsprintf(configfile, "%s/.libvirt/libvirtd.conf", userdir)" has its value checked in "virAsprintf(configfile, "%s/.libvirt/libvirtd.conf", userdir) < 0". /libvirt/daemon/libvirtd.c:916: example_assign: Assigning: "ret" = return value from "virAsprintf(&data->mdns_name, "Virtualization Host")". /libvirt/daemon/libvirtd.c:926: example_checked: "ret" has its value checked in "ret < 0". /libvirt/daemon/libvirtd.c:922: example_assign: Assigning: "ret" = return value from "virAsprintf(&data->mdns_name, "Virtualization Host %s", localhost)". /libvirt/daemon/libvirtd.c:926: example_checked: "ret" has its value checked in "ret < 0". /libvirt/daemon/libvirtd.c:279: example_checked: "virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir)" has its value checked in "virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0". /libvirt/daemon/libvirtd.c:772: example_checked: "virAsprintf(&tmp, "%d:file:%s/log/libvirt/libvirtd.log", virLogGetDefaultPriority(), "/usr/local/var")" has its value checked in "virAsprintf(&tmp, "%d:file:%s/log/libvirt/libvirtd.log", virLogGetDefaultPriority(), "/usr/local/var") == -1". /libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2879: check_return: Calling function "virAsprintf" without checking return value (as is done elsewhere 425 out of 446 times). /libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2879: unchecked_value: No check of the return value of "virAsprintf(&protostr, "-p 0x%04x ", l3_protocols[protoidx].attr)". Error: CHECKED_RETURN: /libvirt/daemon/libvirtd.c:823: example_checked: "virAsprintf(configfile, "%s/.libvirt/libvirtd.conf", userdir)" has its value checked in "virAsprintf(configfile, "%s/.libvirt/libvirtd.conf", userdir) < 0". /libvirt/daemon/libvirtd.c:916: example_assign: Assigning: "ret" = return value from "virAsprintf(&data->mdns_name, "Virtualization Host")". /libvirt/daemon/libvirtd.c:926: example_checked: "ret" has its value checked in "ret < 0". /libvirt/daemon/libvirtd.c:922: example_assign: Assigning: "ret" = return value from "virAsprintf(&data->mdns_name, "Virtualization Host %s", localhost)". /libvirt/daemon/libvirtd.c:926: example_checked: "ret" has its value checked in "ret < 0". /libvirt/daemon/libvirtd.c:279: example_checked: "virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir)" has its value checked in "virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0". /libvirt/daemon/libvirtd.c:772: example_checked: "virAsprintf(&tmp, "%d:file:%s/log/libvirt/libvirtd.log", virLogGetDefaultPriority(), "/usr/local/var")" has its value checked in "virAsprintf(&tmp, "%d:file:%s/log/libvirt/libvirtd.log", virLogGetDefaultPriority(), "/usr/local/var") == -1". /libvirt/src/qemu/qemu_process.c:2397: check_return: Calling function "virAsprintf" without checking return value (as is done elsewhere 425 out of 446 times). /libvirt/src/qemu/qemu_process.c:2397: unchecked_value: No check of the return value of "virAsprintf(&msg, "was paused (%s)", virDomainPausedReasonTypeToString(reason))". Error: DEADCODE: /libvirt/gnulib/lib/strerror_r.c:155: dead_error_condition: On this path, the condition "msg" cannot be true. /libvirt/gnulib/lib/strerror_r.c:153: const: After this line, the value of "msg" is equal to 0. /libvirt/gnulib/lib/strerror_r.c:153: assignment: Assigning: "msg" = "NULL". /libvirt/gnulib/lib/strerror_r.c:156: dead_error_line: Execution cannot reach this statement "return safe_copy(buf, bufle...". Error: DEADCODE: /libvirt/gnulib/lib/strerror.c:47: dead_error_condition: On this path, the condition "msg" cannot be true. /libvirt/gnulib/lib/strerror.c:46: const: After this line, the value of "msg" is equal to 0. /libvirt/gnulib/lib/strerror.c:46: assignment: Assigning: "msg" = "NULL". /libvirt/gnulib/lib/strerror.c:48: dead_error_line: Execution cannot reach this statement "return (char *)msg;". Error: DEADCODE: /libvirt/src/rpc/virnetclient.c:334: dead_error_condition: On this path, the condition "ka" cannot be true. /libvirt/src/rpc/virnetclient.c:276: const: After this line, the value of "ka" is equal to 0. /libvirt/src/rpc/virnetclient.c:314: const: After this line, the value of "ka" is equal to 0. /libvirt/src/rpc/virnetclient.c:276: assignment: Assigning: "ka" = "NULL". /libvirt/src/rpc/virnetclient.c:314: new_values: Noticing condition "ka = virKeepAliveNew(-1, 0U, client, virNetClientKeepAliveSendCB, virNetClientKeepAliveDeadCB, virNetClientEventFree)". /libvirt/src/rpc/virnetclient.c:335: dead_error_begin: Execution cannot reach this statement "virKeepAliveStop(ka);". Error: DEADCODE: /libvirt/src/libvirt.c:8367: dead_error_condition: On this path, the condition "maplen < 0" cannot be true. /libvirt/src/libvirt.c:8367: at_least: After this line, the value of "maplen" is at least 1. /libvirt/src/libvirt.c:8367: new_values: Noticing condition "maplen <= 0". /libvirt/src/libvirt.c:8367: dead_error_line: Execution cannot reach this expression "0 < maxinfo" inside statement "if (!cpumaps ? maplen != 0 ...". Error: DEADCODE: /libvirt/src/libvirt.c:8367: dead_error_condition: On this path, the condition "maxinfo < 0" cannot be true. /libvirt/src/libvirt.c:8360: at_least: After this line, the value of "maxinfo" is at least 1. /libvirt/src/libvirt.c:8360: new_values: Noticing condition "maxinfo < 1". /libvirt/src/libvirt.c:8367: dead_error_line: Execution cannot reach this expression "0 < maplen" inside statement "if (!cpumaps ? maplen != 0 ...". Error: DEADCODE: /libvirt/src/libvirt.c:8367: dead_error_condition: On this path, the condition "maplen < 0" cannot be true. /libvirt/src/libvirt.c:8367: at_least: After this line, the value of "maplen" is at least 1. /libvirt/src/libvirt.c:8367: new_values: Noticing condition "maplen < 0". /libvirt/src/libvirt.c:8367: new_values: Noticing condition "maplen <= 0". /libvirt/src/libvirt.c:8367: dead_error_line: Execution cannot reach this expression "maxinfo < 0" inside statement "if (!cpumaps ? maplen != 0 ...". Error: DEADCODE: /libvirt/src/libvirt.c:8367: dead_error_condition: On this path, the condition "maplen == 0" cannot be true. /libvirt/src/libvirt.c:8367: at_least: After this line, the value of "maplen" is at least 1. /libvirt/src/libvirt.c:8367: new_values: Noticing condition "maplen < 0". /libvirt/src/libvirt.c:8367: new_values: Noticing condition "maplen <= 0". /libvirt/src/libvirt.c:8367: dead_error_line: Execution cannot reach this expression "0" inside statement "if (!cpumaps ? maplen != 0 ...". Error: DEADCODE: /libvirt/src/libvirt.c:8367: dead_error_condition: On this path, the condition "maxinfo < 0" cannot be true. /libvirt/src/libvirt.c:8360: at_least: After this line, the value of "maxinfo" is at least 1. /libvirt/src/libvirt.c:8367: at_least: After this line, the value of "maxinfo" is at least 1. /libvirt/src/libvirt.c:8367: new_values: Noticing condition "maxinfo < 0". /libvirt/src/libvirt.c:8360: new_values: Noticing condition "maxinfo < 1". /libvirt/src/libvirt.c:8367: dead_error_line: Execution cannot reach this expression "maxinfo" inside statement "if (!cpumaps ? maplen != 0 ...". Error: DEADCODE: /libvirt/src/libvirt.c:8288: dead_error_condition: On this path, the condition "maplen < 0" cannot be true. /libvirt/src/libvirt.c:8288: at_least: After this line, the value of "maplen" is at least 1. /libvirt/src/libvirt.c:8288: new_values: Noticing condition "maplen <= 0". /libvirt/src/libvirt.c:8288: dead_error_line: Execution cannot reach this expression "0 < ncpumaps" inside statement "if (ncpumaps < 1 || !cpumap...". Error: DEADCODE: /libvirt/src/libvirt.c:8288: dead_error_condition: On this path, the condition "ncpumaps < 0" cannot be true. /libvirt/src/libvirt.c:8288: at_least: After this line, the value of "ncpumaps" is at least 1. /libvirt/src/libvirt.c:8288: new_values: Noticing condition "ncpumaps < 1". /libvirt/src/libvirt.c:8288: dead_error_line: Execution cannot reach this expression "0 < maplen" inside statement "if (ncpumaps < 1 || !cpumap...". Error: DEADCODE: /libvirt/src/libvirt.c:8288: dead_error_condition: On this path, the condition "maplen < 0" cannot be true. /libvirt/src/libvirt.c:8288: at_least: After this line, the value of "maplen" is at least 1. /libvirt/src/libvirt.c:8288: new_values: Noticing condition "maplen < 0". /libvirt/src/libvirt.c:8288: new_values: Noticing condition "maplen <= 0". /libvirt/src/libvirt.c:8288: dead_error_line: Execution cannot reach this expression "ncpumaps < 0" inside statement "if (ncpumaps < 1 || !cpumap...". Error: DEADCODE: /libvirt/src/libvirt.c:8288: dead_error_condition: On this path, the condition "maplen == 0" cannot be true. /libvirt/src/libvirt.c:8288: at_least: After this line, the value of "maplen" is at least 1. /libvirt/src/libvirt.c:8288: new_values: Noticing condition "maplen < 0". /libvirt/src/libvirt.c:8288: new_values: Noticing condition "maplen <= 0". /libvirt/src/libvirt.c:8288: dead_error_line: Execution cannot reach this expression "0" inside statement "if (ncpumaps < 1 || !cpumap...". Error: DEADCODE: /libvirt/src/libvirt.c:8288: dead_error_condition: On this path, the condition "ncpumaps < 0" cannot be true. /libvirt/src/libvirt.c:8288: at_least: After this line, the value of "ncpumaps" is at least 1. /libvirt/src/libvirt.c:8288: new_values: Noticing condition "ncpumaps < 0". /libvirt/src/libvirt.c:8288: new_values: Noticing condition "ncpumaps < 1". /libvirt/src/libvirt.c:8288: dead_error_line: Execution cannot reach this expression "ncpumaps" inside statement "if (ncpumaps < 1 || !cpumap...". Error: DEADCODE: /libvirt/src/lxc/lxc_controller.c:885: dead_error_condition: On this path, the condition "ret == 4" cannot be true. /libvirt/src/lxc/lxc_controller.c:884: at_most: After this line, the value of "ret" is at most -1. /libvirt/src/lxc/lxc_controller.c:884: new_values: Noticing condition "ret < 0". /libvirt/src/lxc/lxc_controller.c:886: dead_error_line: Execution cannot reach this statement "continue;". Error: FORWARD_NULL: /libvirt/src/util/command.c:1604: var_compare_op: Comparing "cmd->errbuf" to null implies that "cmd->errbuf" might be null. /libvirt/src/util/command.c:1658: alias_transfer: Assigning null: "buf" = "cmd->errbuf". /libvirt/src/util/command.c:1680: var_deref_model: Passing null variable "buf" to function "virReallocN", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.) Error: FORWARD_NULL: /libvirt/src/util/command.c:1597: var_compare_op: Comparing "cmd->outbuf" to null implies that "cmd->outbuf" might be null. /libvirt/src/util/command.c:1655: alias_transfer: Assigning null: "buf" = "cmd->outbuf". /libvirt/src/util/command.c:1680: var_deref_model: Passing null variable "buf" to function "virReallocN", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.) Error: FORWARD_NULL: /libvirt/src/rpc/virnetserver.c:726: var_compare_op: Comparing "srv->clients" to null implies that "srv->clients" might be null. /libvirt/src/rpc/virnetserver.c:748: var_deref_op: Dereferencing null variable "srv->clients". Error: FORWARD_NULL: /libvirt/src/qemu/qemu_driver.c:3568: assign_zero: Assigning: "targetDef" = 0. /libvirt/src/qemu/qemu_driver.c:3630: var_deref_op: Dereferencing null variable "targetDef". Error: FORWARD_NULL: /libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:3567: var_compare_op: Comparing "inst" to null implies that "inst" might be null. /libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:3574: var_deref_op: Dereferencing null variable "inst". Error: FORWARD_NULL: /libvirt/tools/virsh.c:14538: var_compare_op: Comparing "from" to null implies that "from" might be null. /libvirt/tools/virsh.c:14539: var_deref_model: Passing null variable "from" to function "__coverity_strcmp", which dereferences it. Error: FORWARD_NULL: /libvirt/src/qemu/qemu_driver.c:6595: assign_zero: Assigning: "group" = 0. /libvirt/src/qemu/qemu_driver.c:6723: var_deref_model: Passing null variable "group" to function "virCgroupGetMemoryHardLimit", which dereferences it. /libvirt/src/util/cgroup.c:1106: deref_parm_in_call: Function "virCgroupGetValueU64" dereferences parameter "group". /libvirt/src/util/cgroup.c:434: deref_parm_in_call: Function "virCgroupGetValueStr" dereferences parameter "group". /libvirt/src/util/cgroup.c:343: deref_parm_in_call: Function "virCgroupPathOfController" dereferences parameter "group". /libvirt/src/util/cgroup.c:280: deref_parm: Directly dereferencing parameter "group". Error: LOCK: /libvirt/src/datatypes.c:1067: lock: "virMutexLock" locks "secret->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:1074: missing_unlock: Returning without unlocking "secret->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:406: lock: "virMutexLock" locks "network->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:413: missing_unlock: Returning without unlocking "network->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:144: lock: "virMutexLock" locks "conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:151: missing_unlock: Returning without unlocking "conn->lock.lock". Error: LOCK: /libvirt/src/util/event_poll.c:441: lock: "virMutexLock" locks "eventLoop.lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/util/event_poll.c:444: missing_unlock: Returning without unlocking "eventLoop.lock.lock". Error: LOCK: /libvirt/src/datatypes.c:275: lock: "virMutexLock" locks "domain->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:282: missing_unlock: Returning without unlocking "domain->conn->lock.lock". Error: LOCK: /libvirt/src/nwfilter/nwfilter_learnipaddr.c:180: lock: "virMutexLock" locks "ifaceLock->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/nwfilter/nwfilter_learnipaddr.c:182: missing_unlock: Returning without unlocking "ifaceLock->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:1125: lock: "virMutexLock" locks "st->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:1132: missing_unlock: Returning without unlocking "st->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:676: lock: "virMutexLock" locks "pool->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:683: missing_unlock: Returning without unlocking "pool->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:820: lock: "virMutexLock" locks "vol->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:827: missing_unlock: Returning without unlocking "vol->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:1351: lock: "virMutexLock" locks "snapshot->domain->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:1358: missing_unlock: Returning without unlocking "snapshot->domain->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:1260: lock: "virMutexLock" locks "nwfilter->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:1268: missing_unlock: Returning without unlocking "nwfilter->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:938: lock: "virMutexLock" locks "dev->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:945: missing_unlock: Returning without unlocking "dev->conn->lock.lock". Error: LOCK: /libvirt/src/datatypes.c:542: lock: "virMutexLock" locks "iface->conn->lock.lock". /libvirt/src/util/threads-pthread.c:85: lock: "pthread_mutex_lock" locks "m->lock". /libvirt/src/datatypes.c:549: missing_unlock: Returning without unlocking "iface->conn->lock.lock". Error: NEGATIVE_RETURNS: /libvirt/src/util/buf.c:147: negative_return_fn: Function "virBufferGetIndent(buf, true)" returns a negative number. /libvirt/src/util/buf.c:89: return_negative_constant: Explicitly returning negative value "-1". /libvirt/src/util/buf.c:147: var_assign: Assigning: signed variable "indent" = "virBufferGetIndent". /libvirt/src/util/buf.c:157: negative_returns: "indent" is passed to a parameter that cannot be negative. Error: NEGATIVE_RETURNS: /libvirt/src/util/command.c:1620: var_tested_neg: Variable "infd" tests negative. /libvirt/src/util/command.c:1693: negative_returns: "infd" is passed to a parameter that cannot be negative. Error: NULL_RETURNS: /libvirt/src/qemu/qemu_hostdev.c:102: example_checked: "pciDeviceListFind(driver->activePciHostdevs, dev)" has its value checked in "activeDev = pciDeviceListFind(driver->activePciHostdevs, dev)". /libvirt/src/qemu/qemu_hostdev.c:415: example_assign: Assigning: "activeDev" = return value from "pciDeviceListFind(driver->activePciHostdevs, dev)". /libvirt/src/qemu/qemu_hostdev.c:416: example_checked: "activeDev" has its value checked in "activeDev". /libvirt/src/qemu/qemu_hostdev.c:196: example_checked: "pciDeviceListFind(driver->activePciHostdevs, dev)" has its value checked in "other = pciDeviceListFind(driver->activePciHostdevs, dev)". /libvirt/src/qemu/qemu_hostdev.c:268: example_checked: "pciDeviceListFind(pcidevs, dev)" has its value checked in "pcidev = pciDeviceListFind(pcidevs, dev)". /libvirt/src/util/pci.c:1488: example_checked: "pciDeviceListFind(list, dev)" has its value checked in "pciDeviceListFind(list, dev)". /libvirt/src/qemu/qemu_hostdev.c:243: returned_null: Function "pciDeviceListFind" returns null (checked 9 out of 10 times). /libvirt/src/util/pci.c:1572: return_null: Explicitly returning NULL. /libvirt/src/qemu/qemu_hostdev.c:243: var_assigned: Assigning: "activeDev" = null return value from "pciDeviceListFind". /libvirt/src/qemu/qemu_hostdev.c:245: dereference: Dereferencing a pointer that might be null "activeDev" when calling "pciDeviceSetUsedBy". /libvirt/src/util/pci.c:1436: deref_parm: Directly dereferencing parameter "dev". Error: RESOURCE_LEAK: /libvirt/src/util/uuid.c:238: open_fn: Calling opening function "open". /libvirt/src/util/uuid.c:238: var_assign: Assigning: "fd" = handle returned from "open(paths[i], 0)". /libvirt/src/util/uuid.c:239: off_by_one: Testing whether handle "fd" is strictly greater than zero is suspicious. Did you intend to include equality with zero? "fd" leaks when it is zero. /libvirt/src/util/uuid.c:247: leaked_handle: Handle variable "fd" going out of scope leaks the handle. Error: RESOURCE_LEAK: /libvirt/src/esx/esx_vi.c:1893: alloc_arg: Calling allocation function "esxVI_ObjectSpec_Alloc" on "objectSpec". /libvirt/src/esx/esx_vi_types.generated.c:2065: alloc_arg: "esxVI_Alloc" allocates memory that is stored into "*ptrptr". /libvirt/src/esx/esx_vi.c:1626: alloc_arg: "virAllocN" allocates memory that is stored into "*ptrptr". /libvirt/src/util/memory.c:129: alloc_fn: Storage is returned from allocation function "calloc". /libvirt/src/util/memory.c:129: var_assign: Assigning: "*((void **)ptrptr)" = "calloc(count, size)". /libvirt/src/esx/esx_vi.c:2006: leaked_storage: Variable "objectSpec" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK: /libvirt/src/esx/esx_vi.c:1945: alloc_arg: Calling allocation function "esxVI_PropertySpec_Alloc" on "propertySpec". /libvirt/src/esx/esx_vi_types.generated.c:2693: alloc_arg: "esxVI_Alloc" allocates memory that is stored into "*ptrptr". /libvirt/src/esx/esx_vi.c:1626: alloc_arg: "virAllocN" allocates memory that is stored into "*ptrptr". /libvirt/src/util/memory.c:129: alloc_fn: Storage is returned from allocation function "calloc". /libvirt/src/util/memory.c:129: var_assign: Assigning: "*((void **)ptrptr)" = "calloc(count, size)". /libvirt/src/esx/esx_vi.c:2006: leaked_storage: Variable "propertySpec" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK: /libvirt/src/esx/esx_vi.c:3913: alloc_arg: Calling allocation function "esxVI_ObjectSpec_Alloc" on "objectSpec". /libvirt/src/esx/esx_vi_types.generated.c:2065: alloc_arg: "esxVI_Alloc" allocates memory that is stored into "*ptrptr". /libvirt/src/esx/esx_vi.c:1626: alloc_arg: "virAllocN" allocates memory that is stored into "*ptrptr". /libvirt/src/util/memory.c:129: alloc_fn: Storage is returned from allocation function "calloc". /libvirt/src/util/memory.c:129: var_assign: Assigning: "*((void **)ptrptr)" = "calloc(count, size)". /libvirt/src/esx/esx_vi.c:4075: leaked_storage: Variable "objectSpec" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK: /libvirt/src/esx/esx_vi.c:3920: alloc_arg: Calling allocation function "esxVI_PropertySpec_Alloc" on "propertySpec". /libvirt/src/esx/esx_vi_types.generated.c:2693: alloc_arg: "esxVI_Alloc" allocates memory that is stored into "*ptrptr". /libvirt/src/esx/esx_vi.c:1626: alloc_arg: "virAllocN" allocates memory that is stored into "*ptrptr". /libvirt/src/util/memory.c:129: alloc_fn: Storage is returned from allocation function "calloc". /libvirt/src/util/memory.c:129: var_assign: Assigning: "*((void **)ptrptr)" = "calloc(count, size)". /libvirt/src/esx/esx_vi.c:4075: leaked_storage: Variable "propertySpec" going out of scope leaks the storage it points to. Error: RESOURCE_LEAK: /libvirt/src/qemu/qemu_driver.c:6107: alloc_arg: Calling allocation function "qemuDomainParseDeviceWeightStr" on "devices". /libvirt/src/qemu/qemu_driver.c:5918: alloc_arg: "virAllocN" allocates memory that is stored into "result". /libvirt/src/util/memory.c:129: alloc_fn: Storage is returned from allocation function "calloc". /libvirt/src/util/memory.c:129: var_assign: Assigning: "*((void **)ptrptr)" = "calloc(count, size)". /libvirt/src/qemu/qemu_driver.c:5957: var_assign: Assigning: "*dw" = "result". /libvirt/src/qemu/qemu_driver.c:6127: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. Error: RETURN_LOCAL: /libvirt/gnulib/lib/careadlinkat.c:101: local_ptr_assign_local: Assigning: "buffer" = "stack_buf" (address of local variable "stack_buf"). /libvirt/gnulib/lib/careadlinkat.c:105: local_ptr_assign_ptr: Assigning: "buf" = "buffer". /libvirt/gnulib/lib/careadlinkat.c:152: return_local_addr_alias: Returning pointer "buf" which points to local variable "stack_buf". Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1876: deref_ptr_in_call: Dereferencing pointer "machineName". /libvirt/src/vbox/vbox_tmpl.c:1935: check_after_deref: Dereferencing "machineName" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1388: deref_ptr_in_call: Dereferencing pointer "machineNameUtf8". /libvirt/src/vbox/vbox_tmpl.c:1413: check_after_deref: Dereferencing "machineNameUtf8" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1876: deref_ptr_in_call: Dereferencing pointer "machineName". /libvirt/src/vbox/vbox_tmpl.c:1935: check_after_deref: Dereferencing "machineName" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1876: deref_ptr_in_call: Dereferencing pointer "machineName". /libvirt/src/vbox/vbox_tmpl.c:1935: check_after_deref: Dereferencing "machineName" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1388: deref_ptr_in_call: Dereferencing pointer "machineNameUtf8". /libvirt/src/vbox/vbox_tmpl.c:1413: check_after_deref: Dereferencing "machineNameUtf8" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1388: deref_ptr_in_call: Dereferencing pointer "machineNameUtf8". /libvirt/src/vbox/vbox_tmpl.c:1413: check_after_deref: Dereferencing "machineNameUtf8" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1876: deref_ptr_in_call: Dereferencing pointer "machineName". /libvirt/src/vbox/vbox_tmpl.c:1935: check_after_deref: Dereferencing "machineName" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1876: deref_ptr_in_call: Dereferencing pointer "machineName". /libvirt/src/vbox/vbox_tmpl.c:1935: check_after_deref: Dereferencing "machineName" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1388: deref_ptr_in_call: Dereferencing pointer "machineNameUtf8". /libvirt/src/vbox/vbox_tmpl.c:1413: check_after_deref: Dereferencing "machineNameUtf8" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1388: deref_ptr_in_call: Dereferencing pointer "machineNameUtf8". /libvirt/src/vbox/vbox_tmpl.c:1413: check_after_deref: Dereferencing "machineNameUtf8" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1876: deref_ptr_in_call: Dereferencing pointer "machineName". /libvirt/src/vbox/vbox_tmpl.c:1935: check_after_deref: Dereferencing "machineName" before a null check. Error: REVERSE_INULL: /libvirt/src/vbox/vbox_tmpl.c:1388: deref_ptr_in_call: Dereferencing pointer "machineNameUtf8". /libvirt/src/vbox/vbox_tmpl.c:1413: check_after_deref: Dereferencing "machineNameUtf8" before a null check. Error: UNINIT: /libvirt/src/util/command.c:154: var_decl: Declaring variable "sig_action" without initializer. /libvirt/src/util/command.c:234: uninit_use_in_call: Using uninitialized value "sig_action": field "sig_action".sa_restorer is uninitialized when calling "sigaction". Error: UNINIT: /libvirt/tools/virsh.c:581: var_decl: Declaring variable "sig_action" without initializer. /libvirt/tools/virsh.c:587: uninit_use_in_call: Using uninitialized value "sig_action": field "sig_action".sa_restorer is uninitialized when calling "sigaction". Error: UNINIT: /libvirt/src/rpc/virnetserver.c:283: var_decl: Declaring variable "sig_action" without initializer. /libvirt/src/rpc/virnetserver.c:297: uninit_use_in_call: Using uninitialized value "sig_action": field "sig_action".sa_restorer is uninitialized when calling "sigaction". Error: UNUSED_VALUE: /libvirt/tools/virsh.c:7837: returned_pointer: Pointer "br_node" returned by "virXPathNode("./bridge", ctxt)" is never used. Error: UNUSED_VALUE: /libvirt/tools/virsh.c:7842: returned_pointer: Pointer "if_node" returned by "virXPathNode("./bridge/interface[2]", ctxt)" is never used.
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list