On Mon, Dec 05, 2011 at 10:38:49AM -0700, Eric Blake wrote:
> Over time, Fedora and RHEL RPMs have often backported upstream
> patches that touched configure.ac and/or Makefile.am; this
> necessitates rerunning the autotools for the patch to be effective.
> Making this part of the spec file will make it easier for future
> backports to pull patches without thinking about this issue.
>
> * libvirt.spec.in (BuildRequires): Add autotools.
> (%build): Use them before configure.
> ---
> libvirt.spec.in | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 06c949b..462421a 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -334,6 +334,9 @@ Requires: libcgroup
> %endif
>
> # All build-time requirements
> +BuildRequires: autoconf
> +BuildRequires: automake
> +BuildRequires: libtool
> BuildRequires: python-devel
> %if %{with_systemd}
> BuildRequires: systemd-units
> @@ -721,6 +724,7 @@ of recent versions of Linux (and other OSes).
> %define init_scripts --with-init_script=redhat
> %endif
>
> +autoreconf -if
> %configure %{?_without_xen} \
> %{?_without_qemu} \
> %{?_without_openvz} \
NACK, we really shouldn't do this by default IMHO - regenerating autotools
has not always been foolproof when newer autotools are released. If we want
to include this for help of downstream, then it should be protected by a
conditional statement, so it is off by default and you can set
%define enable_autoconf 1
at the top of the spec to turn it on.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list