Re: [PATCH libvirt-glib 12/15] Use test -d FOO && test -d BAR instead of test -d FOO -a -d BAR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ACK

On Thu, Dec 01, 2011 at 02:05:40PM +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> For greater portability do not rely on the test binary having
> a -a option
> ---
>  configure.ac |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4092bef..805cd9b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -138,8 +138,8 @@ if test "$with_python" != "no" ; then
>      fi
>      if test "$PYTHON_VERSION" != ""
>      then
> -	if test -r $with_python/include/python$PYTHON_VERSION/Python.h -a \
> -	   -d $with_python/lib/python$PYTHON_VERSION/site-packages
> +	if test -r $with_python/include/python$PYTHON_VERSION/Python.h && \
> +	   test -d $with_python/lib/python$PYTHON_VERSION/site-packages
>  	then
>  	    PYTHON_INCLUDES=$with_python/include/python$PYTHON_VERSION
>  	    PYTHON_SITE_PACKAGES=$libdir/python$PYTHON_VERSION/site-packages
> -- 
> 1.7.6.4
> 
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: pgpjow6A1eGCz.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]