On Mon, Nov 28, 2011 at 04:32:07PM +0100, Christophe Fergeau wrote:
> This class derives from GObject and wraps an xmlDocPtr. It will be
> useful to refcount xmlDoc so that it can be shared between multiple
> GVirConfigObject instances.
> ---
> libvirt-gconfig/Makefile.am | 4 +-
> libvirt-gconfig/libvirt-gconfig-xml-doc.c | 137 +++++++++++++++++++++++++++++
> libvirt-gconfig/libvirt-gconfig-xml-doc.h | 66 ++++++++++++++
> 3 files changed, 206 insertions(+), 1 deletions(-)
> create mode 100644 libvirt-gconfig/libvirt-gconfig-xml-doc.c
> create mode 100644 libvirt-gconfig/libvirt-gconfig-xml-doc.h
ACK
> +extern gboolean debugFlag;
> +
> +#define DEBUG(fmt, ...) do { if (G_UNLIKELY(debugFlag)) g_debug(fmt, ## __VA_ARGS__); } while (0)
This can be deleted before pushing to GIT
> +
> + DEBUG("Finalize GVirConfigXmlDoc=%p", doc);
..just call g_debug() directly
(Likewise if it occurs in any other patches in this series).
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list