On 30.11.2011 10:32, Alex Jia wrote: > On 11/30/2011 05:20 PM, Michal Privoznik wrote: >> On 30.11.2011 09:25, ajia@xxxxxxxxxx wrote: >>> From: Alex Jia<ajia@xxxxxxxxxx> >>> >>> The 'true' bool value should be 1, and false is 0. >>> >>> https://bugzilla.redhat.com/show_bug.cgi?id=758590 >>> >>> Signed-off-by: Alex Jia<ajia@xxxxxxxxxx> >>> --- >>> tools/virsh.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/tools/virsh.c b/tools/virsh.c >>> index 01da8e5..618b0c1 100644 >>> --- a/tools/virsh.c >>> +++ b/tools/virsh.c >>> @@ -1745,7 +1745,7 @@ cmdDomblklist(vshControl *ctl, const vshCmd *cmd) >>> VIR_FREE(source); >>> } >>> >>> - ret = 0; >>> + ret = true; >>> >>> cleanup: >>> VIR_FREE(disks); >> I'd change commit message: >> >> Fix cmdDomblklist to return true on success instead of 0 >> >> But I can live with your's too. > Michal, thanks. >> ACK >> >> Michal > I've pushed this with altered commit message. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list