On Tue, Nov 29, 2011 at 09:33:09AM -0700, Eric Blake wrote:
> On 11/29/2011 08:44 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> >
> > hostPMFeatures is a bitmask, but the VIR_NODE_SUSPEND_TARGET
> > constants are from an enum. Thus the code was checking the
> > wrong bit values
>
> Yep - regression introduced in patch 1/14. Maybe you should squash this
> in to that patch, so that bisecting doesn't hit the regression (although
> that would mean patching a different file, since you moved the function
> location in the meantime). Up to you if you want to go to the hassle.
It wasn't a regression actually. This code was still using the
duplicate enum at that point:
enum virHostPMCapability {
VIR_HOST_PM_S3, /* Suspend-to-RAM */
VIR_HOST_PM_S4, /* Suspend-to-Disk */
VIR_HOST_PM_HYBRID_SUSPEND, /* Hybrid-Suspend */
VIR_HOST_PM_LAST
};
So AFAICT, it was broken from the start.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list