On Nov 28, 2011, at 11:23 AM, Eric Blake wrote: s/xbox/vbox/ in the subject
Whoops... Hope I didn't disappoint anybody hoping for libvirt support on the xbox.
On 11/28/2011 07:26 AM, Lorin Hochstein wrote: virt-xml-validate fails when run on a domain XML file of type 'vbox'.
For failing test case, see https://bugzilla.redhat.com/show_bug.cgi?id=757097
This patch updates the XML schema so it accepts type 'vbox'.
---
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 8968ee6..444592c 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -85,6 +85,7 @@
<value>qemu</value>
<value>lxc</value>
<value>openvz</value>
+ <value>vbox</value>
<value>test</value>
ACK that we had a problem. Actually, it was more than just vbox missing. virDomainVirtTypeToString in domain_conf.c has the full list; on the other hand, that list had elements that aren't in use by any existing hypervisor driver. Here's what I'm squashing into your patch before pushing. I also added you to AUTHORS; let me know if I need to update any preferred spelling.
Patch looks good to me (including AUTHORS spelling).
Lorin -- Lorin Hochstein, Computer Scientist USC Information Sciences Institute 703.812.3710
|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list