On Wed, Nov 23, 2011 at 02:44:42PM -0700, Eric Blake wrote: > Here's the latest state of Lei's patch series with all my comments > folded in. I may have a few more tweaks to make now that I'm at > the point of testing things with both old qemu (graceful rejection) > and new qemu (sensical return values), so it may be a day or two (or > even a weekend, since this is a holiday weekend for me) before I > actually push this, so it wouldn't hurt if anyone else wants to > review in the meantime. > > Lei Li (7): > Add new API virDomain{Set, Get}BlockIoTune > Add virDomain{Set, Get}BlockIoTune support to the remote driver > Support block I/O throttle in XML > Implement virDomain{Set, Get}BlockIoTune for the qemu driver > Enable the blkdeviotune command in virsh > Support virDomain{Set, Get}BlockIoTune in the python API > Add tests for blkdeviotune > > daemon/remote.c | 64 ++++ > docs/formatdomain.html.in | 39 +++ > docs/schemas/domaincommon.rng | 122 +++++-- > include/libvirt/libvirt.h.in | 63 ++++ > python/generator.py | 2 + > python/libvirt-override-api.xml | 16 + > python/libvirt-override.c | 178 ++++++++++ > src/conf/domain_conf.c | 90 +++++- > src/conf/domain_conf.h | 14 + > src/driver.h | 20 ++ > src/libvirt.c | 148 +++++++++ > src/libvirt_public.syms | 6 + > src/qemu/qemu_command.c | 31 ++ > src/qemu/qemu_driver.c | 340 ++++++++++++++++++++ > src/qemu/qemu_monitor.c | 33 ++ > src/qemu/qemu_monitor.h | 8 + > src/qemu/qemu_monitor_json.c | 176 ++++++++++ > src/qemu/qemu_monitor_json.h | 8 + > src/qemu/qemu_monitor_text.c | 151 +++++++++- > src/qemu/qemu_monitor_text.h | 8 + > src/remote/remote_driver.c | 57 ++++ > src/remote/remote_protocol.x | 27 ++- > src/remote_protocol-structs | 24 ++ > .../qemuxml2argv-blkdeviotune.args | 7 + > .../qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml | 30 ++ > tests/qemuxml2argvtest.c | 2 + > tests/qemuxml2xmltest.c | 1 + > tools/virsh.c | 244 ++++++++++++++ > tools/virsh.pod | 30 ++ > 29 files changed, 1900 insertions(+), 39 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune.xml ACK to the serie once the bug on 3/7 is fixed, if possible fix the couple of other small nits :-) thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list