On 11/15/2011 02:02 AM, Lei Li wrote: > Implement the block I/O throttle setting and getting support to qemu > driver. > > Signed-off-by: Lei Li <lilei@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx> > --- > src/qemu/qemu_driver.c | 342 ++++++++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_monitor.c | 37 +++++ > src/qemu/qemu_monitor.h | 22 +++ > src/qemu/qemu_monitor_json.c | 186 +++++++++++++++++++++++ > src/qemu/qemu_monitor_json.h | 10 ++ > src/qemu/qemu_monitor_text.c | 165 ++++++++++++++++++++ > src/qemu/qemu_monitor_text.h | 10 ++ > 7 files changed, 772 insertions(+), 0 deletions(-) 'make syntax-check' didn't like this one: libvirt_unmarked_diagnostics src/qemu/qemu_monitor_json.c-3332- ), "total_bytes_sec"); src/qemu/qemu_monitor_json.c-3338- ), "read_bytes_sec"); src/qemu/qemu_monitor_json.c-3344- ), "write_bytes_sec"); src/qemu/qemu_monitor_json.c-3350- ), "total_iops_sec"); src/qemu/qemu_monitor_json.c-3356- ), "read_iops_sec"); src/qemu/qemu_monitor_json.c-3362- ), "write_iops_sec"); maint.mk: found unmarked diagnostic(s) I ended up shuffling those lines around. Also, prohibit_empty_lines_at_EOF src/qemu/qemu_monitor_json.c src/qemu/qemu_monitor_text.c maint.mk: empty line(s) or no newline at EOF I stripped the spurious whitespace. > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 5f4a18d..0a4eaa9 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -94,6 +94,8 @@ > > #define QEMU_NB_MEM_PARAM 3 > > +#define QEMU_NB_BLKIOTHROTTLE_PARAM 6 Naming should match the public API. After fixing the syntax errors, I then got: qemu/qemu_driver.c: In function 'qemuDomainSetBlockIoTune': qemu/qemu_driver.c:10881:34: error: 'virDomainDiskDef' has no member named 'blkdeviotune' Ouch - your patches are submitted out of order. Looks like I'll have to defer further review of this one until domain_conf.h is updated. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list