On 2011年11月22日 16:07, Daniel Veillard wrote:
On Tue, Nov 22, 2011 at 11:27:04AM +0800, taget@xxxxxxxxxxxxxxxxxx wrote:
From: Eli Qiao<taget@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Eli Qiao<taget@xxxxxxxxxxxxxxxxxx>
When configure the URI aliase like this in 'libvirt.conf':
uri_aliases = [
"jj#j=qemu+ssh://root@127.0.0.1/system",
"sleet=qemu+ssh://root@xxxxxxxxxxxxxxxxxxxxxxx/system",
]
virsh -c jj#j
No, we don't want # to appear in aliases as this will lead to
confusion
I think Eli's purpose is to see the more sensiable message by removing
the early checking. But I don't see the more sensiable message with
applying the patch.
It will show this error message:
'no connection driver available for No connection for URI jj#j'
Actually ，we expect this message below：
Malformed 'uri_aliases' config entry 'jj#j=qemu+ssh://root@127.0.0.1/system', aliases may only container 'a-Z, 0-9, _, -'
Give this patch to fix this error.
---
src/libvirt.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 1518ed2..17e073e 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -1054,11 +1054,6 @@ virConnectOpenResolveURIAlias(const char *alias, char **uri)
*uri = NULL;
- /* Short circuit to avoid doing URI alias resolution
- * when it clearly isn't an valid alias */
- if (strspn(alias, URI_ALIAS_CHARS) != strlen(alias))
- return 0;
-
if (!(config = virConnectConfigFile()))
goto cleanup;
I disagree, I don't see any need to have complex aliases values.
The principle is precisely to keep them simple. Use "jj" instead of "jj#j"
for example.
Disagree too. The simple early checking ensure it doesn't flow into
the loop, which is just waste.
Osier
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list