On Mon, Nov 21, 2011 at 10:12 PM, Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote: > On Mon, Nov 21, 2011 at 9:02 PM, Zeeshan Ali (Khattak) > <zeeshanak@xxxxxxxxx> wrote: >> + g_return_val_if_fail(err == NULL || *err == NULL, FALSE); As I explained on IRC, it is justified AFAICT. Either you pass a 'NULL' as the error arg or you pass an uninitialized place-holder for error. Fixed other issues you pointed to. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list