On 17.11.2011 00:33, Eric Blake wrote:
> On 11/16/2011 06:14 AM, Michal Privoznik wrote:
>> Now, when we support multiple consoles per domain,
>> the vm->def->console[0] can still remain an alias
>> for vm->def->serial[0]; However, we need to copy
>> it's source definition as well otherwise we'll regress
>> on virDomainOpenConsole.
>> ---
>> src/conf/domain_conf.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++
>> src/conf/domain_conf.h | 2 +
>> src/libvirt_private.syms | 1 +
>> src/qemu/qemu_process.c | 19 +++++++++--
>> 4 files changed, 90 insertions(+), 4 deletions(-)
>
> ACK if you squash this in to avoid the memory leak (you may want to wait
> for Dave to confirm that squashing this in still works in his testing):
>
It works for me with squashed part. The 'reproducer' is really simple -
just run 'virsh console $vm' where vm has console defined like this:
<domain type='kvm'>
...
<devices>
...
<serial type='pty'>
<target port='0'/>
</serial>
<console type='pty'>
<target type='serial' port='0'/>
</console>
...
</devices>
</domain>
I assume it works for Dave as well; so I am pushing it.
Thanks
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list