On Thu, Nov 17, 2011 at 06:04:32AM -0500, Laine Stump wrote: > On 11/15/2011 06:14 AM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange"<berrange@xxxxxxxxxx> > > > >Rename ifaceMacvtapLinkAdd to virNetDevMacVLanCreate and > >ifaceLinkDel to virNetDevMacVLanDelete. Strictly speaking > >the latter isn't restricted to macvlan devices, but that's > >the only use libvirt has for it. > > Also removed the macaddrsize arg from virNetDevMacVLanCreate. This > is bringing back some memory of a network device type that had a mac > address > 6 bytes in length, but I can't recall what it was, and > anyway everything else in libvirt assumes VIR_MAC_BUFLEN (6) anyway. Yes, I should have mentioned that. Although the API had a macaddr length parameter, the caller had hardcoded '6' as the length. Given that everything in libvirt presumes VIR_MAC_BUFLEN, I didn't see the point in keeping macaddr length configurable for this one API. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list