On Tue, Nov 15, 2011 at 12:15:17PM +0100, Christophe Fergeau wrote: > Hey, > > On Fri, Nov 11, 2011 at 03:28:34PM +0100, Marc-André Lureau wrote: > > The functions declaration should be put in -private.h . Marking > > definition G_GNUC_INTERNAL would also make it more obvious. > > > > It would also less confuse gir-scanner which doesn't know about libxml types. > > At this point, I'm undecided whether these functions should be private or > not. Having some way to directly manipulate the XML data can be useful when > you want to generate some config data not yet handled by libvirt-gconfig, > but on the other hand, it makes it really easy to shoot yourself in the > foot. > I'm fine with marking them private for now. Yep, lets be conservative and make them private. If we find a compelling case where we need them public in the future, we can easily revisit the decision. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list