On 11/14/2011 09:33 PM, Lei Li wrote:
> Support Block I/O Throttle setting and query to remote driver.
>
> Signed-off-by: Lei Li <lilei@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> +
> +struct remote_domain_get_block_io_throttle_args {
> + remote_nonnull_domain dom;
> + remote_nonnull_string disk;
> + int nparams;
> + unsigned int flags;
> +};
Hmm, just wondering - if we use 'remote_string disk', then we can allow
NULL for disk and params as a way to populate nparams as the maximum
possible for all types of disks in a given domain, rather than returning
a possibly-varying nparams specific to each disk. Might be worth a
tweak to the libvirt.c documentation to allow NULL disk as a special case.
> @@ -2564,7 +2586,9 @@ enum remote_procedure {
> REMOTE_PROC_DOMAIN_SNAPSHOT_NUM_CHILDREN = 246, /* autogen autogen priority:high */
> REMOTE_PROC_DOMAIN_SNAPSHOT_LIST_CHILDREN_NAMES = 247, /* autogen autogen priority:high */
> REMOTE_PROC_DOMAIN_EVENT_DISK_CHANGE = 248, /* skipgen skipgen */
> - REMOTE_PROC_DOMAIN_OPEN_GRAPHICS = 249 /* skipgen skipgen */
> + REMOTE_PROC_DOMAIN_OPEN_GRAPHICS = 249, /* skipgen skipgen */
> + REMOTE_PROC_DOMAIN_SET_BLOCK_IO_THROTTLE = 250, /* skipgen skipgen */
> + REMOTE_PROC_DOMAIN_GET_BLOCK_IO_THROTTLE = 251 /* skipgen skipgen */
>
> /*
> * Notice how the entries are grouped in sets of 10 ?
Oops - you skipped right over the comment here, and forgot your blank
line :)
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list