On Thu, Nov 10, 2011 at 9:33 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > The way it's done is just a band-aid though. The need for this > 'type' member in GVirConfigInterface and GVirConfigDeviceDisk is > a clear indication that they should be separate class. You mean there should be a seperate class for source type? otherwise, patch looks fine -- Marc-André Lureau -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list