On Sat, Nov 05, 2011 at 08:58:59PM +0100, Matthias Bolte wrote: > 2011/10/20 Daniel P. Berrange <berrange@xxxxxxxxxx>: > > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > > > The default console type may vary based on the OS type. ie a Xen > > paravirt guests wants a 'xen' console, while a fullvirt guests > > wants a 'serial' console. > > > > A plain integer default console type in the capabilities does > > not suffice. Instead introduce a callback that is passed the > > OS type. > > > > * src/conf/capabilities.h: Use a callback for default console > > type > > * src/conf/domain_conf.c, src/conf/domain_conf.h: Use callback > > for default console type. Add missing LXC/OpenVZ console types. > > * src/esx/esx_driver.c, src/libxl/libxl_conf.c, > > src/lxc/lxc_conf.c, src/openvz/openvz_conf.c, > > src/phyp/phyp_driver.c, src/qemu/qemu_capabilities.c, > > src/uml/uml_conf.c, src/vbox/vbox_tmpl.c, > > src/vmware/vmware_conf.c, src/xen/xen_hypervisor.c, > > src/xenapi/xenapi_driver.c: Set default console type callback > > --- > > With this patch virt-aa-helper-test fails on Ubuntu: > > FAIL: exited with '1' > console: '--dryrun -r -u libvirt-00000000-0000-0000-0000-0123456789ab': > FAIL: exited with '1' > console (pty): '--dryrun -r -u > libvirt-00000000-0000-0000-0000-0123456789ab': > FAIL: exited with '1' > console (pipe): '--dryrun -r -u > libvirt-00000000-0000-0000-0000-0123456789ab': > FAIL: virt-aa-helper-test I've just sent a patch which ought to solve this Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list