Re: [libvirt[]PATCH v2] Fix URI alias prefix matching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Wen,

On Tuesday 01 November 2011 04:08:24 Wen Ruo Lv wrote:
> With /etc/libvirt/libvirt.conf below:
> uri_aliases = [
>   "hail=qemu:///system",
>   "sleet=qemu+ssh://root 9 115 122 57/system",
>   "sam=qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock",
> ]
> Issue "virsh -c hailly" results in matching "hail=qemu:///system"
...
> -        if (STREQLEN(entry->str, alias, offset-entry->str)) {
> +        if (STREQLEN(entry->str, alias, strlen(alias))) {

Now you have it the other way around, that any prefix matches:
 "virsh -c hai" will match "hail".
Why not simply use STREQ instead of STREQLEN?

Sincerely
Philipp
-- 
Philipp Hahn           Open Source Software Engineer      hahn@xxxxxxxxxxxxx
Univention GmbH        Linux for Your Business        fon: +49 421 22 232- 0
Mary-Somerville-Str.1  D-28359 Bremen                 fax: +49 421 22 232-99
                                                   http://www.univention.de/

Attachment: signature.asc
Description: This is a digitally signed message part.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]