Re: [PATCH] daemon: plug memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/01/2011 01:38 AM, Eric Blake wrote:
On 10/29/2011 11:12 AM, ajia@xxxxxxxxxx wrote:
From: Alex Jia<ajia@xxxxxxxxxx>

Detected by Coverity. Leak introduced in commit baf2ff7.

* daemon/remote.c: Clean up on failure.

Signed-off-by: Alex Jia<ajia@xxxxxxxxxx>
---
  daemon/remote.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/daemon/remote.c b/daemon/remote.c
index f5141b9..173cd92 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -498,6 +498,8 @@ static int remoteRelayDomainEventDiskChange(virConnectPtr conn ATTRIBUTE_UNUSED,

  mem_error:
      virReportOOMError();
+    VIR_FREE(oldSrcPath_p);
+    VIR_FREE(newSrcPath_p);

NACK.  Already fixed by commit 457d46ca.

Yeah, Michal has fixed this issue, thanks for your review.

Alex

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]