On Thu, Oct 27, 2011 at 05:20:05PM +0800, Lei HH Li wrote: > + if (flags) { > + ret = virAsprintf(&cmd, "block_set_io_throttle %s %llu %llu %llu %llu %llu %llu", > + device, > + info->bps, > + info->bps_rd, > + info->bps_wr, > + info->iops, > + info->iops_rd, > + info->iops_wr); Please combine the parameters onto fewer lines. -- Adam Litke <agl@xxxxxxxxxx> IBM Linux Technology Center -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list