Re: [PATCH] snapshot: use correct qmp monitor command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/19/2011 03:25 AM, lvroyce wrote:
Tested by:lvroyce
test with cmd snapshot-create domain --disk-only ,patch works when qmp
or hmp monitor accessible,

Got trace below when issue cmd "snapshot-delete domain --snapshotname
name",no "delvm/savevm" in qmp, only "delvm/savevm" commands in hmp.Is
this for future compability?

2011-09-19 16:15:54.938: 25648: debug : qemuMonitorJSONIOProcessLine:115
: Line [{"id": "libvirt-11", "error": {"class": "CommandNotFound",
"desc": "The command delvm has not been found", "data": {"name":
"delvm"}}}]
2011-09-19 16:15:54.939: 25666: debug : virJSONValueToString:1071 :
result={"execute":"human-monitor-command","arguments":{"command-line":"delvm
\"1319011620\""},"id":"libvirt-12"}
2011-09-19 16:15:54.939: 25666: debug : qemuMonitorJSONCommandWithFd:224
: Send command
'{"execute":"human-monitor-command","arguments":{"command-line":"delvm
\"1319011620\""},"id":"libvirt-12"}' for write with FD -1

That's normal. There are quite a few commands that don't exist in QMP, where we have to use HMP fallback. The trace just shows that we attempted QMP first, but the QMP failure does not matter since the HMP variant worked.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]