On Tue, Oct 18, 2011 at 12:32:33PM +0100, Daniel P. Berrange wrote: > On Fri, Oct 07, 2011 at 11:40:49AM +0200, Christophe Fergeau wrote: > > @@ -277,6 +306,8 @@ const gchar *gvir_config_object_get_schema(GVirConfigObject *config) > > } > > > > /* NB: the xmlDocPtr must not be freed by the caller */ > > +/* gupnp has wrapped xmlDoc in a gobject */ > > +/* not really useful, can be obtained from xmlNode::doc */ > > I guess the reason for doing that would be to avoid any libxml2 data > types in the public API. Might be worth considering in the future. Ah, I hadn't thought of this reason, but at the same time I was wondering if it's ok to leak libxml2 data types in the public API. The reason I'm considering it is to get refcounting on xmlDocPtr as you mentioned in a later patch in this series. Christophe
Attachment:
pgpx214eZYUiX.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list