On Fri, Oct 07, 2011 at 11:41:05AM +0200, Christophe Fergeau wrote: > This test has 3 duplicate "name" nodes in the domain XML, I don't > know what the right behaviour is in this case :) Well first of all this is obviously a non-conforming XML document, so if the application is using the schema validation check they will get an error. If they're not validating against the schema, then IMHO any behaviour you care to implement is acceptable, but for sanity I'd pick either the first, or last node rather than a random node :-) > --- > libvirt-gconfig/tests/test-domain-duplicate.xml | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > create mode 100644 libvirt-gconfig/tests/test-domain-duplicate.xml > > diff --git a/libvirt-gconfig/tests/test-domain-duplicate.xml b/libvirt-gconfig/tests/test-domain-duplicate.xml > new file mode 100644 > index 0000000..acff40a > --- /dev/null > +++ b/libvirt-gconfig/tests/test-domain-duplicate.xml > @@ -0,0 +1,7 @@ > +<domain type='xen' id='3'> > + <name>bar</name> > + <name>foo</name> > + <name>foobar</name> > + <uuid>4dea22b31d52d8f32516782e98ab3fa0</uuid> > + <description>Some human readable description</description> > +</domain> Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list