Re: [PATCH 3/3] Use virBufferEscapeShell in virNetSocketNewConnectSSH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/13/2011 03:02 PM, Guido Günther wrote:
On Wed, Oct 12, 2011 at 05:22:02PM -0600, Eric Blake wrote:
On 10/12/2011 04:40 PM, Guido Günther wrote:
to escape the netcat command since it's passed to the shell. Adjust
expected test case output accordingly.
---

Rebase this on top of my comments for 1/3 (no long lines).  Also,
add one more test where $NC is something that actually proves things
work with shell meta-characters, perhaps by passing 'nc -4' as the
value that eventually supplies the %s for $NC, so that .expectOut
will include: sh -c 'if ''nc -4'' -q 2>&1 ....

Done too.

ACK.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]