On Mon, Oct 10, 2011 at 05:14:44PM -0600, Eric Blake wrote: > On 10/09/2011 09:16 PM, Daniel Veillard wrote: > >On Fri, Sep 30, 2011 at 05:09:24PM -0600, Eric Blake wrote: > >>Sometimes, we only care about one branch of the snapshot hierarchy. > >>Make it easier to list a single branch, by using the new APIs. > >> > >>Technically, I could emulate these new virsh options on old servers > >>by doing a complete dump, then scraping xml to filter out just the > >>snapshots that I care about, but I didn't want to do that in this patch. > >> > > > > ACK, > > > >I'm unsure about the emulation need, except for a server running 0.9.6 > >and a newer client ... > > Not just 0.9.6, but any server where snapshots are supported (all > the way back to 0.8.0, when snapshots were introduced). okay, re-ACK > So that's why patches 3-5 introduced the necessary emulation; and by > implementing the virsh changes prior to the qemu change, I was able > to prove that both the emulation and the new API work. > > I'll push this as-is when I get to the end of your comments. thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list