Re: [PATCH 1/2] snapshot: implement getparent for esx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/9/30 Daniel Veillard <veillard@xxxxxxxxxx>:
> On Thu, Sep 29, 2011 at 02:38:24PM -0600, Eric Blake wrote:
>> Pretty easy to paste together compared to existing functions.
>>
>> * src/esx/esx_driver.c (esxDomainSnapshotGetParent): New function.
>> ---
>>
>> I can only compile-test this; I'm relying on someone with an actual
>> esx setup to actually test it.  Also, I didn't see anything in
>> existing code that would efficiently implement
>> virDomainSnapshotNumChildren; there may an API that I'm not aware of,
>> but someone else will have to implement that API (Matthias?)
>
>  The 2 patches looks just fine to me but agreed someone with the
> setup should check those and give the final ACK :-)
>
> Daniel

I'll probably have some time this weekend to have a look at it.

-- 
Matthias Bolte
http://photron.blogspot.com

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]