Re: [PATCH v2] qemu: add return value check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/29/2011 01:10 AM, Eric Blake wrote:
On 09/28/2011 02:00 AM, ajia@xxxxxxxxxx wrote:
From: Alex Jia<ajia@xxxxxxxxxx>

* src/qemu/qemu_migration.c: if 'vmdef' is NULL, the function
   virDomainSaveConfig still dereferences it, it doesn't make
   sense, so should add return value check to make sure 'vmdef'
   is non-NULL before calling virDomainSaveConfig, in addition,
   in order to debug later, also should record error information
   into log.

Signed-off-by: Alex Jia<ajia@xxxxxxxxxx>
---
  src/qemu/qemu_migration.c |    5 ++++-
  1 files changed, 4 insertions(+), 1 deletions(-)

ACK and pushed, after fixing your trailing whitespace bug that 'make syntax-check' tripped on.

Eric, thanks a lot.

Alex

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]